Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTRun][Calc]Improve handling of non-base 10 numbers #36700

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PesBandi
Copy link
Contributor

@PesBandi PesBandi commented Jan 4, 2025

Summary of the Pull Request

PR Checklist

  • Closes: [PTRun][Calc] Improve handling of non base 10 numbers #36699
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: No need
  • New binaries: None
  • Documentation updated: No need

Detailed Description of the Pull Request / Additional comments

The Mages dep has been recently upgraded to v3.0.0, introducing support for octal numbers and hence requiring this PR. Therefore it would be great if it got merged in this release cycle, so that there wouldn't be a release with v3.0.0 that doesn't properly support it.

Validation Steps Performed

Manually tested in PTRun + added tests

@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Jan 6, 2025
@htcfreek
Copy link
Collaborator

htcfreek commented Jan 6, 2025

@jaimecbernardo
Can someone review this please to get it in for 0.88.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants