Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Registry Preview] Copy context menu, data toltip, MULTI_SZ fix #36631

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Dec 29, 2024

Summary of the Pull Request

This PR...

  • fixes line break parsing for REG_MULTI_SZ
  • adds a tool tip to show the multiline version of value data.
  • adds context menu with various copy actions to Key tree and Value list.

Screenshots

image

image

image

image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Manual testing.

@htcfreek htcfreek self-assigned this Dec 29, 2024
@htcfreek htcfreek added Issue-Bug Something isn't working Idea-Enhancement New feature or request on an existing product Product-Registry Preview Refers to the Registry Preview PowerToy labels Dec 29, 2024
@htcfreek htcfreek requested a review from randyrants December 29, 2024 19:33
@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Dec 29, 2024
@htcfreek htcfreek changed the title [Registry Preview] Copy context menu, data toltip, MULTI-SZ fix [Registry Preview] Copy context menu, data toltip, MULTI_SZ fix Dec 29, 2024
@htcfreek

This comment has been minimized.


private void CopyToClipboardEntryWithPath()
{
ClipboardHelper.CopyToClipboardAction($"{Key}\r\n{Name}\r\n{Type}\r\n{Value}");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it is better to copy with a blank line between the information instead of a simple line break? 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine like this. Users can treat after.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a test, seems to be working pretty well. Thanks you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 44f170d into microsoft:main Jan 17, 2025
11 checks passed
@htcfreek htcfreek deleted the PT_RegPrevCopy branch January 17, 2025 15:10
@htcfreek
Copy link
Collaborator Author

🔥🔥🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Issue-Bug Something isn't working Needs-Review This Pull Request awaits the review of a maintainer. Product-Registry Preview Refers to the Registry Preview PowerToy
Projects
Development

Successfully merging this pull request may close these issues.

2 participants