-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Registry Preview] Copy context menu, data toltip, MULTI_SZ fix #36631
Conversation
This comment has been minimized.
This comment has been minimized.
src/modules/registrypreview/RegistryPreviewUILib/Strings/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
|
||
private void CopyToClipboardEntryWithPath() | ||
{ | ||
ClipboardHelper.CopyToClipboardAction($"{Key}\r\n{Name}\r\n{Type}\r\n{Value}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if it is better to copy with a blank line between the information instead of a simple line break? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine like this. Users can treat after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it a test, seems to be working pretty well. Thanks you for the contribution!
🔥🔥🔥 |
Summary of the Pull Request
This PR...
Screenshots
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Manual testing.