Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New utility]Sysinternals ZoomIt #35880

Merged
merged 97 commits into from
Jan 16, 2025
Merged

Conversation

jaimecbernardo
Copy link
Collaborator

@jaimecbernardo jaimecbernardo commented Nov 11, 2024

Summary of the Pull Request

This PR integrates the Sysinternals tool ZoomIt into PowerToys.
Has the PowerToys Settings page with the options allowed from ZoomIt.
Also updates some C++ dependencies.

Still missing/WIP:

  • spell check
  • Make it pass CI
  • OOBE page
  • Entries in Dashboard and quick access
  • Settings icons / images
  • Telemetry
  • Logging
  • Tweak copyright issues
  • Tweak Community.md
  • Verify what else might we need to localize
  • Test it more

PR Checklist

@jaimecbernardo jaimecbernardo requested a review from a team as a code owner January 7, 2025 10:11

This comment has been minimized.

This comment has been minimized.

jaimecbernardo and others added 5 commits January 7, 2025 14:33
* Remove unneeded files

* Make build compatible with Sysinternals
* Separate PowerToys ZoomIt product name

To help maintain the Sysinternals branding in the standalone version.

* Clarify branding-related includes
<controls:PageLink x:Uid="LearnMore_ZoomIt" Link="https://aka.ms/PowerToysOverview_ZoomIt" />
</controls:SettingsPageControl.PrimaryLinks>
<controls:SettingsPageControl.SecondaryLinks>
<controls:PageLink Link="https://learn.microsoft.com/en-us/sysinternals/downloads/zoomit" Text="SysInternals ZoomIt by Mark Russinovich, Alex Mihaiuc, John Stephens" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, change SysInternals to Sysinternals.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the standalone solution file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed and pushed. Thank you!

@@ -34,6 +34,7 @@ Adoumie
Advaith
alekhyareddy
Aleks
amihaiuc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add foxmsft, here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foxmsft That's for spellcheck, not attribution. foxmsft is not mentioned anywhere. Are you talking about attributing to your GitHub user elsewhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the change, anyway 😄 Pushed

Copy link
Collaborator

@cinnamon-msft cinnamon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

@jaimecbernardo jaimecbernardo merged commit 21fd509 into main Jan 16, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants