-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New utility]Sysinternals ZoomIt #35880
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Remove unneeded files * Make build compatible with Sysinternals
* Separate PowerToys ZoomIt product name To help maintain the Sysinternals branding in the standalone version. * Clarify branding-related includes
<controls:PageLink x:Uid="LearnMore_ZoomIt" Link="https://aka.ms/PowerToysOverview_ZoomIt" /> | ||
</controls:SettingsPageControl.PrimaryLinks> | ||
<controls:SettingsPageControl.SecondaryLinks> | ||
<controls:PageLink Link="https://learn.microsoft.com/en-us/sysinternals/downloads/zoomit" Text="SysInternals ZoomIt by Mark Russinovich, Alex Mihaiuc, John Stephens" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, change SysInternals
to Sysinternals
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already done.
src/modules/ZoomIt/ZoomIt/ZoomIt.sln
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the standalone solution file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed and pushed. Thank you!
@@ -34,6 +34,7 @@ Adoumie | |||
Advaith | |||
alekhyareddy | |||
Aleks | |||
amihaiuc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add foxmsft, here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@foxmsft That's for spellcheck, not attribution. foxmsft is not mentioned anywhere. Are you talking about attributing to your GitHub user elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the change, anyway 😄 Pushed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉
Summary of the Pull Request
This PR integrates the Sysinternals tool ZoomIt into PowerToys.
Has the PowerToys Settings page with the options allowed from ZoomIt.
Also updates some C++ dependencies.
Still missing/WIP:
PR Checklist