Adds action/function suffix to tag names for action/function operations #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update operation tags generation * Refactor operation tag generation * Update unit tests * Update integration test files * Update release note * Update src/Microsoft.OpenApi.OData.Reader/Operation/EdmOperationOperationHandler.cs Co-authored-by: Andrew Omondi <[email protected]> * Account for nullability * Remove unnecessary code --------- Co-authored-by: Andrew Omondi <[email protected]>
timayabi2020
requested review from
xuzhg,
irvinesunday,
darrelmiller,
danielmbaluka,
gavinbarron,
millicentachieng,
andrueastman and
baywet
as code owners
baywet
requested changes
Jan 17, 2025
src/Microsoft.OpenApi.OData.Reader/Microsoft.OpenAPI.OData.Reader.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.OData.Reader/Operation/EdmOperationOperationHandler.cs
Outdated
Show resolved
Hide resolved
…tionHandler.cs Co-authored-by: Vincent Biret <[email protected]>
…of using Odata operation segment. Updated test files and regenerated yaml and json resource files
|
baywet
approved these changes
Jan 20, 2025
timayabi2020
pushed a commit
that referenced
this pull request
Jan 20, 2025
This was referenced Jan 21, 2025
| Assert.Equal("Customers.Customer.MyFunction1.MyFunction2-4d93", operation2.OperationId); | ||
| Assert.Equal("Customers.Customer.MyFunction1.MyFunction2-a2b2", operation3.OperationId); | ||
| Assert.Equal("Customers.Customer.MyFunction1.MyFunction2-7bea", operation4.OperationId); | ||
| Assert.Equal("Customers.Customer.MyFunction1.MyFunction2-6b6d", operation1.OperationId); |
There was a problem hiding this comment.
Looks like this change is resulting in duplicate operation ids as captured in the validation at microsoftgraph/msgraph-metadata#752
Ideally, the logic here should results in all 4 of the operationIds in the tests being unique
There was a problem hiding this comment.
@timayabi2020 can you prioritize a fix for this regression please?
Thank Andrew for catching this and sorry for not seeing it during the review
There was a problem hiding this comment.
No worries. Created #645 to resolve this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #640
Cherry picks from #586 and adds "Actions" or "Functions" as suffixes to the tag. This will
enable the powershell mappings to be updated to target the paths more precisely to fix the incorrect mappings.
enable the user functions/actions to still remain in their current modules by targeting operationIds like user.*.Actions.