Fixups for running pytest via VSCode #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
commented
Jan 17, 2025
bpkroth
commented
Jan 17, 2025
mlos_bench/mlos_bench/tests/config/schemas/optimizers/test_optimizer_schemas.py
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
motus
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Fixups for running pytest via VSCode
Description
@motus noticed that running all tests in VSCode was hanging inside a DevContainer on MacOS.
After some debugging I determined that there was some mismatch between discovering tests and running them, specifically for the GridSearchOptimizer. This was true on the CLI as well.
Adding it to the
__init__.pyfor that submodule seems to fix the issue.Type of Change
Testing
Additional Notes (optional)
Don't know of others like this but I wonder if that's an issue now ...