Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable libc++ bound checks #6767

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Enable libc++ bound checks #6767

merged 5 commits into from
Jan 17, 2025

Conversation

maxtropets
Copy link
Collaborator

@maxtropets maxtropets commented Jan 16, 2025 •
edited
Loading

This adds use of hardened libc++ and closes #6720

  • In release, mode=FAST
  • In debug, mode=DEBUG

Works only on Azure Linux with newer libc++, is simply ignored on Ubuntu 20.04 builds.

@maxtropets maxtropets self-assigned this Jan 16, 2025
@maxtropets maxtropets added the run-long-test Run Long Test job label Jan 16, 2025
@maxtropets maxtropets force-pushed the f/azure-linux-bound-check-all branch from 8c37bdc to 958e16c Compare January 16, 2025 22:21
@maxtropets maxtropets changed the title [WIP] [DRAFT] bound checks - all tests Enable libc++ bound checks Jan 16, 2025
@maxtropets maxtropets marked this pull request as ready for review January 16, 2025 22:22
@maxtropets maxtropets requested a review from a team as a code owner January 16, 2025 22:22
achamayou
achamayou reviewed Jan 17, 2025
View reviewed changes
cmake/preproject.cmake Outdated Show resolved Hide resolved
@maxtropets maxtropets marked this pull request as draft January 17, 2025 12:57
@maxtropets maxtropets changed the title Enable libc++ bound checks [DRAFT-CHECK-CI-FAILS] Enable libc++ bound checks Jan 17, 2025
@maxtropets maxtropets force-pushed the f/azure-linux-bound-check-all branch from 1760b35 to 6b68276 Compare January 17, 2025 13:00
@maxtropets maxtropets removed the run-long-test Run Long Test job label Jan 17, 2025
@maxtropets maxtropets force-pushed the f/azure-linux-bound-check-all branch from 6b68276 to e46c018 Compare January 17, 2025 14:09
@maxtropets maxtropets force-pushed the f/azure-linux-bound-check-all branch 2 times, most recently from 263aced to 3cb8919 Compare January 17, 2025 14:20
@maxtropets maxtropets changed the title [DRAFT-CHECK-CI-FAILS] Enable libc++ bound checks Enable libc++ bound checks Jan 17, 2025
@maxtropets maxtropets marked this pull request as ready for review January 17, 2025 14:20
@maxtropets maxtropets added the run-long-test Run Long Test job label Jan 17, 2025
@achamayou achamayou added this pull request to the merge queue Jan 17, 2025
Merged via the queue into microsoft:main with commit 516b158 Jan 17, 2025
28 checks passed
@achamayou achamayou deleted the f/azure-linux-bound-check-all branch January 17, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

@eddyashton eddyashton Awaiting requested review from eddyashton

Assignees

@maxtropets maxtropets

Labels
run-long-test Run Long Test job
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try enable bound checks
2 participants
@maxtropets @achamayou