Fix public exposure in Guacamole service #4236
Conversation
…n configuration to the data
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 47b233e. ♻️ This comment has been updated with latest results. |
ShakutaiGit
changed the title
tamirkamara
changed the title
…/microsoft/AzureTRE into fix_exposed_externally_guacamole
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12561666906 (with refid (in response to this comment from @ShakutaiGit) |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12561666906 (with refid (in response to this comment from @ShakutaiGit) |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12562335261 (with refid (in response to this comment from @ShakutaiGit) |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12569060271 (with refid (in response to this comment from @ShakutaiGit) |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12569920962 (with refid (in response to this comment from @ShakutaiGit) |
|
/help |
|
🤖 pr-bot 🤖 Hello! You can use the following commands: (in response to this comment from @ShakutaiGit) |
|
/test-destroy-env |
|
Destroying PR test environment (RG: rg-tre0a106d24)... (run: https://github.com/microsoft/AzureTRE/actions/runs/12570062604) |
|
Destroying branch test environment (RG: rg-trecfb25c6d)... (run: https://github.com/microsoft/AzureTRE/actions/runs/12570062604) |
|
Branch test environment destroy complete (RG: rg-trecfb25c6d) |
|
PR test environment destroy complete (RG: rg-tre0a106d24) |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12570286147 (with refid (in response to this comment from @ShakutaiGit) |
1 similar comment
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12570286147 (with refid (in response to this comment from @ShakutaiGit) |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12579100697 (with refid (in response to this comment from @ShakutaiGit) |
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 47b233e) (in response to this comment from @ShakutaiGit) |
Resolves #4199
What is being addressed
The current behavior does not allow for dynamic configuration of the
public_network_access_enabledparameter in the Guacamole workspace template.This parameter is critical for determining whether the service should be exposed externally or restricted to internal access only.
How is this addressed
public_network_access_enabledparameter with a default value offalseto prevent public exposure by default.web_app.tfto map the parameter tovar.is_exposed_externally.data.tffor better organization.