-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMK support for core resources #4149
Conversation
…02-cmk-support
…02-cmk-support
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 95c6b6a. ♻️ This comment has been updated with latest results. |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11916800932 (with refid (in response to this comment from @yuvalyaron) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11923480499 (with refid (in response to this comment from @yuvalyaron) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11923684873 (with refid (in response to this comment from @yuvalyaron) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11930799088 (with refid (in response to this comment from @yuvalyaron) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with few comments
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/11995889638 (with refid (in response to this comment from @yuvalyaron) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small comment to document all the new config
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 6f9e0fd) (in response to this comment from @yuvalyaron) |
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 95c6b6a) (in response to this comment from @yuvalyaron) |
Has support been adding for the CMK configuration through Env Vars in GitHub? |
#4148 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #4142, #4143
Part of #4002
What is being addressed
Added CMK support for Storage accounts and VM storage disks for core TRE resources.
Added the option to use an external Key Vault to store the CMKs
How is this addressed
users set
enable_cmk_encryption: true
in theconfig.yaml
,and either
encryption_kv_name
orexternal_key_store_id
for the key vault.