[BUG] Investigate changing the sideEffects: false to list only the fi…

…les that include the shims module from the all AI modules so that webpack can evaluate correctly #1509 Investigate removing the globals __extends() and __assign() populated by applicationinsights-shims #1280
microsoft · Apr 14, 2021 · b5c2503 · b5c2503
1 parent 22d3787
commit b5c2503
Show file tree

Hide file tree

Showing 57 changed files with 912 additions and 3,847 deletions.
diff --git a/.gitignore b/.gitignore
@@ -249,6 +249,7 @@ temp
 # Rush files
 common/temp/**
 package-deps.json
+package-lock.json
 
 # test output
 aicore.tests.js*

diff --git a/AISKU/package.json b/AISKU/package.json
@@ -46,6 +46,7 @@
         "grunt-ts": "^6.0.0-beta.22",
         "grunt-tslint": "^5.0.2",
         "globby": "^11.0.0",
+        "magic-string": "^0.25.7",
         "@rollup/plugin-commonjs": "^15.1.0",
         "@rollup/plugin-node-resolve": "^9.0.0",
         "@rollup/plugin-replace": "^2.3.3",
@@ -56,11 +57,12 @@
         "source-map-loader": "^0.2.3",
         "tslint": "^5.19.0",
         "tslint-config-prettier": "^1.18.0",
-        "typescript": "2.5.3"
+        "typescript": "2.5.3",
+        "tslib": "^1.13.0"
     },
     "dependencies": {
         "@microsoft/dynamicproto-js": "^1.1.1",
-        "@microsoft/applicationinsights-shims" : "1.0.3",
+        "@microsoft/applicationinsights-shims" : "2.0.0",
         "@microsoft/applicationinsights-analytics-js": "2.6.1",
         "@microsoft/applicationinsights-channel-js": "2.6.1",
         "@microsoft/applicationinsights-common": "2.6.1",

diff --git a/AISKU/src/applicationinsights-web.ts b/AISKU/src/applicationinsights-web.ts
@@ -1,5 +1,3 @@
-import '@microsoft/applicationinsights-shims';
-
 export {
     IApplicationInsights,
     Snippet,

diff --git a/AISKU/tsconfig.json b/AISKU/tsconfig.json
@@ -9,8 +9,9 @@
     "alwaysStrict": true,
     "suppressImplicitAnyIndexErrors": true,
     "allowSyntheticDefaultImports": true,
-    "importHelpers": false,
+    "importHelpers": true,
     "noEmitHelpers": true,
+    "skipLibCheck": true,
     "forceConsistentCasingInFileNames": true,
     "declaration": true,
     "declarationDir": "AISKU/types",

diff --git a/AISKULight/index.ts b/AISKULight/index.ts
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-import '@microsoft/applicationinsights-shims';
 import {
     IConfiguration,
     AppInsightsCore,

diff --git a/AISKULight/package.json b/AISKULight/package.json
@@ -25,19 +25,21 @@
         "grunt-run": "^0.8.1",
         "grunt-ts": "^6.0.0-beta.22",
         "globby": "^11.0.0",
+        "magic-string": "^0.25.7",
         "@rollup/plugin-commonjs": "^15.1.0",
         "@rollup/plugin-node-resolve": "^9.0.0",
         "@rollup/plugin-replace": "^2.3.3",
         "rollup-plugin-cleanup": "3.2.1",
         "rollup": "^2.32.0",
         "source-map-loader": "^0.2.3",
         "typescript": "2.5.3",
+        "tslib": "^1.13.0",
         "tslint": "^5.19.0",
         "tslint-config-prettier": "^1.18.0"
     },
     "dependencies": {
         "@microsoft/dynamicproto-js": "^1.1.1",
-        "@microsoft/applicationinsights-shims" : "1.0.3",
+        "@microsoft/applicationinsights-shims" : "2.0.0",
         "@microsoft/applicationinsights-common": "2.6.1",
         "@microsoft/applicationinsights-channel-js": "2.6.1",
         "@microsoft/applicationinsights-core-js": "2.6.1"

diff --git a/AISKULight/tsconfig.json b/AISKULight/tsconfig.json
@@ -9,8 +9,9 @@
     "alwaysStrict": true,
     "suppressImplicitAnyIndexErrors": true,
     "allowSyntheticDefaultImports": true,
-    "importHelpers": false,
+    "importHelpers": true,
     "noEmitHelpers": true,
+    "skipLibCheck": true,
     "forceConsistentCasingInFileNames": true,
     "declaration": true,
     "declarationDir": "AISKULight/types",

diff --git a/channels/applicationinsights-channel-js/package.json b/channels/applicationinsights-channel-js/package.json
@@ -29,20 +29,22 @@
         "grunt-run": "^0.8.1",
         "grunt-ts": "^6.0.0-beta.22",
         "globby": "^11.0.0",
+        "magic-string": "^0.25.7",
         "@rollup/plugin-commonjs": "^15.1.0",
         "@rollup/plugin-node-resolve": "^9.0.0",
         "@rollup/plugin-replace": "^2.3.3",
         "rollup-plugin-cleanup": "3.2.1",
         "rollup": "^2.32.0",
         "typescript": "2.5.3",
+        "tslib": "^1.13.0",
         "tslint": "^5.19.0",
         "tslint-config-prettier": "^1.18.0",
         "qunit": "^2.9.1",
         "sinon": "^7.3.1"
     },
     "dependencies": {
         "@microsoft/dynamicproto-js": "^1.1.1",
-        "@microsoft/applicationinsights-shims" : "1.0.3",
+        "@microsoft/applicationinsights-shims" : "2.0.0",
         "@microsoft/applicationinsights-core-js": "2.6.1",
         "@microsoft/applicationinsights-common": "2.6.1"
     },

diff --git a/channels/applicationinsights-channel-js/src/applicationinsights-channel-js.ts b/channels/applicationinsights-channel-js/src/applicationinsights-channel-js.ts
@@ -1,3 +1 @@
-import '@microsoft/applicationinsights-shims';
-
 export { Sender } from "./Sender";
diff --git a/channels/applicationinsights-channel-js/tsconfig.json b/channels/applicationinsights-channel-js/tsconfig.json
@@ -10,8 +10,9 @@
     "suppressImplicitAnyIndexErrors": true,
     "allowSyntheticDefaultImports": true,
     "forceConsistentCasingInFileNames": true,
-    "importHelpers": false,
+    "importHelpers": true,
     "noEmitHelpers": true,
+    "skipLibCheck": true,
     "declaration": true,
     "declarationDir": "channels/applicationinsights-channel-js/types",
     "outDir": "dist-esm",

diff --git a/common/Tests/Framework/package.json b/common/Tests/Framework/package.json
@@ -41,10 +41,14 @@
         "@rollup/plugin-replace": "^2.3.3",
         "rollup": "^2.32.0",
         "typescript": "2.5.3",
+        "tslib": "^1.13.0",
         "qunit": "^2.9.1",
-        "sinon": "^7.3.1"
+        "sinon": "^7.3.1",
+        "globby": "^11.0.0",
+        "magic-string": "^0.25.7"
     },
     "dependencies": {
+        "@microsoft/applicationinsights-shims" : "2.0.0",
         "@microsoft/dynamicproto-js": "^1.1.1"
     }
 }
diff --git a/common/Tests/Framework/rollup.config.js b/common/Tests/Framework/rollup.config.js
@@ -1,4 +1,5 @@
 import nodeResolve from "@rollup/plugin-node-resolve";
+import { updateDistEsmFiles } from "../../../tools/updateDistEsm/updateDistEsm";
 
 const version = require("./package.json").version;
 const outputName = "ai-test-framework";
@@ -29,6 +30,8 @@ const nodeUmdRollupConfigFactory = () => {
   return nodeRollupConfig;
 }
 
+updateDistEsmFiles({}, banner);
+
 export default [
   nodeUmdRollupConfigFactory(),
 ];
diff --git a/common/Tests/Framework/tsconfig.json b/common/Tests/Framework/tsconfig.json
@@ -7,8 +7,9 @@
       "moduleResolution": "node",
       "target": "es5",
       "forceConsistentCasingInFileNames": true,
-      "importHelpers": false,
+      "importHelpers": true,
       "noEmitHelpers": true,
+      "skipLibCheck": true,
       "alwaysStrict": true,
       "declaration": true,
       "outDir": "dist-esm/",
Original file line number	Diff line number	Diff line change
		@@ -1,3 +1 @@
		import '@microsoft/applicationinsights-shims';

		export { Sender } from "./Sender";