Fix builds hanging if server cannot start #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the server factory fails to start the test resources service, then we'd wait indefinitely for the server port file to appear, which causes builds to hang. Closes #785
melix
force-pushed
the
cc/fix-hang-startup
branch
from
5acdbf3 to
1c15623
Compare
|
alvarosanchez
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server factory fails to start the test resources service, then we'd wait indefinitely for the server port file to appear, which causes builds to hang.
Note: this requires updating the build plugins to use the latest test resources build tools library.
Closes #785