Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature propsal: Generate client factories for each client #748

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

andriy-dmytruk
Copy link
Contributor

Generates the client factories for each micronaut-oraclecloud-bmc-... module.
Therefore the clients will be able to be injected out of the box without the need for the micronaut-oraclelcloud-sdk or reactor modules.

@graemerocher
Copy link
Contributor

sounds good, not sure why the build is failing 🤔

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

16.1% 16.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@andriy-dmytruk
Copy link
Contributor Author

Just found this. Should we merge it?
@graemerocher @yawkat

@graemerocher graemerocher merged commit c50795d into master Jan 8, 2024
18 of 19 checks passed
@graemerocher graemerocher deleted the generate-client-factories-separately branch January 8, 2024 16:05
@graemerocher graemerocher added the type: enhancement New feature or request label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants