Fix dangling request when connection is closed without error #11528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a connection is closed without error, a streaming body would never finish, no response would be written, and thus the request would never be released. This patch changes PipeliningServerHandler so that: - a normal closure is treated as an EOF by the streaming inbound handler - the outbound handler can properly discard a response written after the PipeliningServerHandler is already being removed Found by fuzzing.
graemerocher
approved these changes
Jan 22, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a connection is closed without error, a streaming body would never finish, no response would be written, and thus the request would never be released. This patch changes PipeliningServerHandler so that:
Found by fuzzing.