Replace HttpAttributes with accessors #11324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attributes are a suboptimal way of adding metadata to requests and responses, both because they need a string lookup, and because they require conversion.
|
it's not super important that core code is migrated from HttpAttributes immediately, so #11309 can stay as-is. the main concern is users and non-core micronaut projects. |
# Conflicts: # http-server-netty/src/main/java/io/micronaut/http/server/netty/NettyHttpRequest.java
graemerocher
requested changes
Jan 23, 2025
| * @since 4.8.0 | ||
| */ | ||
| @SuppressWarnings("removal") | ||
| public final class ClientAttributes { |
There was a problem hiding this comment.
is this regarded public API?
| */ | ||
| @Deprecated(forRemoval = true) |
There was a problem hiding this comment.
add @since to all deprecated annotations
graemerocher
approved these changes
Jan 23, 2025
dstepanov
approved these changes
Jan 24, 2025
# Conflicts: # http-server-netty/src/main/java/io/micronaut/http/server/netty/RoutingInBoundHandler.java
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes are a suboptimal way of adding metadata to requests and responses, both because they need a string lookup, and because they require conversion.