Merge pull request #4 from cpietsch/master

added vendorId for windows (0D28)
microbit-foundation · Feb 20, 2023 · 3b057a8 · 3b057a8
2 parents 91e0610 + 885d110
commit 3b057a8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/client/MBFirmataClient.js b/client/MBFirmataClient.js
@@ -152,7 +152,7 @@ class MicrobitFirmataClient {
 		.then((ports) => {
 			for (var i = 0; i < ports.length; i++) {
 				var p = ports[i];
-				if ((p.vendorId == '0d28' || p.vendorId == '0D28') && (p.productId == '0204')) {
+				if ((p.vendorId == "0d28" || p.vendorId == "0D28") && (p.productId == '0204')) {
 					return p.comName;
 				}
 			}
@@ -168,6 +168,7 @@ class MicrobitFirmataClient {
 				console.log("No micro:bit found; is your board plugged in?");
 				return null;
 			}
+			return null
 		});
 	}
 
@@ -199,7 +200,7 @@ class MicrobitFirmataClient {
 					this.boardVersion = this.boardVersionFromSerialNumber(p.serialNumber);
 				}
 			}
-			return null;
+			return this;
 		})
 	}