-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getAlpha #669
Add getAlpha #669
Conversation
This PR also simplifies the alpha diversity functions. Previously we combined different diversity functions to be used through addAlpha. We did minimal changes to get the functions working, however, that led to overhead and suboptimal solutions (internal function was calling other internal function that was calling other...). Moreover, ace index calculation was not even working correctly because of these suboptimal choices that were made previously. |
Seems good, just one note that the original functions were splitted into informative categories (richness, evenness, diversity, dominance, rarity). It would be good to keep that information (what index belongs to what category) in the documentation at least. |
Yes, the documentation has this information |
TODO and things to answer:
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #669 +/- ##
==========================================
- Coverage 70.11% 69.28% -0.83%
==========================================
Files 47 47
Lines 5778 5828 +50
==========================================
- Hits 4051 4038 -13
- Misses 1727 1790 +63 ☔ View full report in Codecov by Sentry. |
Currently, we have only addAlpha function that adds values to colData. getAlpha function returns data.frame with the indices without adding them to colData