Use x/term on Unix systems, deduplicate tscreen_*.go
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace unix.Ioctl* in tscreen_{linux,solaris}.go and Syscall6 in
tscreen_{bsd,darwin}.go with functions in golang.org/x/term.
- Merge tscreen_windows.go with tscreen_stub.go, and adjust
tscreen_darwin.go to tscreen_linux.go. Merge other files with
tscreen_linux.go and rename to tscreen_unix.go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior that occurs when calling
syscall.Syscalland passingsyscall.SYS_IOCTLin OpenBSD has been changed in Go 1.23 becausesyscall(2)is removed in OpenBSD 7.5. There may be changes in any platform where usingsyscall.Syscall*will not work, soSyscall6is replaced withgolang.org/x/term.*. There are other changes with functionality on BSD systems because the files are merged.I do not know how micro was able to start up properly on old OpenBSD versions even though
unsafe.Pointerwas not converted touintptrin arguments like written in the 4th pattern written in documentation, but the screen would be blank in newer versions.Micro seemed to start up properly when I tested using an OpenBSD 7.6 VM. I do not have a MacOS machine so I cannot test if there are no bugs on MacOS. The changes may not be tested and thought well enough.
Fixes zyedidia/micro#3557