Init Channels support #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le service). Added gitignore file
| @@ -10,7 +10,7 @@ var AzureRequest = function ( config ) { | |||
| AzureRequest.prototype.buildConfig = function ( config ) { | |||
|
|
|||
| this.config = config || {} | |||
| this.config.mediaURI = "https://media.windows.net/API/" | |||
| this.config.mediaURI = "https://media.windows.net/api/" | |||
There was a problem hiding this comment.
I don't think this is correct. Docs maintain an uppercase API.
https://msdn.microsoft.com/en-us/library/azure/hh973617.aspx
|
Wow, I apparently am horrible at checking on my old repos. I'm sorry this escaped my notice for the better part of the year! Thank you for the PR. I'd be happy to merge after the couple nitpicks and the removal of the .gitignore since that is really user specific. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love this wrapper, i find it very useful.
It lacks of Channels support, that it's exactly what i need, so i'll try to add the support for it :-)