-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rough support for email notifications #3
base: main
Are you sure you want to change the base?
Conversation
Hey thanks Alex, this is awesome. I've been crazy busy over the past week sorry, but I'll get this merged this weekend :) |
No worries! Honestly it's a bit of a rough implementation, so it's mostly meant to perhaps just give you a starting point on how to more properly integrate it in the original design of the tool! |
I completely missed the requests for change! I attempted to fix the conflicts, please do a double check, as I might have missed something (hopefully not) |
Any news about the email function? Best regards, Web |
@Webfeger fixed some leftover conflicts and waiting for review |
@AlexKalopsia does this work for you as it is currently implemented? If so, could you please provide example documentation (e.g. in the
I'm happy to review this PR in detail, but only once I can see that it works. |
Added a rough support for email notifications. Currently it works as an alternative to PB (so either-or).