Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rough support for email notifications #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AlexKalopsia
Copy link

Added a rough support for email notifications. Currently it works as an alternative to PB (so either-or).

@michaelhball
Copy link
Owner

Hey thanks Alex, this is awesome. I've been crazy busy over the past week sorry, but I'll get this merged this weekend :)

@AlexKalopsia
Copy link
Author

No worries! Honestly it's a bit of a rough implementation, so it's mostly meant to perhaps just give you a starting point on how to more properly integrate it in the original design of the tool!

@AlexKalopsia
Copy link
Author

AlexKalopsia commented Mar 16, 2022

I completely missed the requests for change! I attempted to fix the conflicts, please do a double check, as I might have missed something (hopefully not)

@Webfeger
Copy link

Webfeger commented Jun 6, 2022

Any news about the email function?

Best regards, Web

@AlexKalopsia
Copy link
Author

@Webfeger fixed some leftover conflicts and waiting for review

@michaelhball
Copy link
Owner

michaelhball commented Jun 21, 2022

@AlexKalopsia does this work for you as it is currently implemented? If so, could you please provide example documentation (e.g. in the README or in the PR description) that details what someone has to do to use it. For example,

  • do I have to run an smtp server locally?
  • Do I have to do something differently for different email providers? (perhaps Gmail would be the most obvious place to start)
  • Does this work if I have 2FA on my gmail account?

I'm happy to review this PR in detail, but only once I can see that it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants