v1.8.10 - Fix some navigation issues

Closes #44
mgziminsky · Oct 4, 2020 · d8836bd · d8836bd
1 parent 969990b
commit d8836bd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,6 @@
+v1.8.10
+- Fix some navigation issues with internal link cleaning enabled - closes #44
+
 v1.8.9
 - Block additional background tracking and metrics submission
 - Fix video volume adjustment slider - closes #43

diff --git a/manifest.json b/manifest.json
@@ -1,6 +1,6 @@
 {
   "name": "__MSG_extensionName__",
-  "version": "1.8.9",
+  "version": "1.8.10",
   "description": "__MSG_extensionDescription__",
   "default_locale": "en",
   "icons": { "128": "src/icon.png" },

diff --git a/src/util.js b/src/util.js
@@ -27,8 +27,7 @@ function isAllowedTarget(e) {
     // Walk through event target and parents until the currentTarget looking for an element that clicks are allowed on
     while (e.currentTarget.parentNode !== checkTarget) {
         const role = checkTarget.attributes.role;
-        if (checkTarget.tagName === "A" && (!checkTarget.hasAttribute("href") || checkTarget.getAttribute("href") === "#")) {
-            e.preventDefault();
+        if (checkTarget.tagName === "A" && checkTarget.hostname === location.hostname) {
             return true;
         } else if (role && config.roles.includes(role.value.toUpperCase())) {
             return true;