Skip to content
This repository has been archived by the owner on Apr 29, 2021. It is now read-only.

Added select/deselect all support #33

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added select/deselect all support #33

wants to merge 5 commits into from

Conversation

hjkta
Copy link

@hjkta hjkta commented Dec 28, 2018

No description provided.

@mgibbs189
Copy link
Owner

@hjkta thanks for the PR!

@mgibbs189
Copy link
Owner

@hjkta Would it make more sense to just have a single Toggle all button?

That way, we could add a toggleAllText setting that works just like noResultsText... i.e. if the setting is empty, then no "Toggle all" would appear.

@hjkta
Copy link
Author

hjkta commented Jan 10, 2019

Good idea. Also, I thought about replacing this buttons to single option «Toggle all» with checkbox, like the other ones.
What do you think about it?

@mgibbs189
Copy link
Owner

@hjkta Good question. That might work too. Since it would be just another fs-option, the only issue might be the need for a bunch of extra code to treat it differently from the other "normal" fs-options

@gibrany
Copy link

gibrany commented Mar 28, 2019

hi i was wondering why it reload the pages when i click button select all or deselect all?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants