Change the key of the response hash on the module_result #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fixes #62? (A description on that would be helpful: mezuro/prezento#370 (comment)). What do you think about a additional acceptance test? It would ensure there will be no regression on this. |
|
ping @marcosddourado |
|
ping @DylanGuedes |
|
@vitorbaraujo , would you talk to @DylanGuedes to the MES'2017 team proceed with this PR? |
|
Yes, the issue is fairly simple, and the PR isn't that old, so they should continue with it. Manzo asked for acceptance tests, what is great, but Marcos just changed the name of the hash, so I think that he didn't know what to test about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.