Use params in _put #54
Conversation
| @@ -246,7 +246,7 @@ async def _get(self) -> JsonDict: | |||
| @raises(401, "CouchDB Server Administrator privileges required") | |||
| @raises(412, "Database already exists") | |||
| async def _put(self, **params: Any) -> JsonDict: | |||
| _, json = await self._remote._put(self.endpoint) | |||
| _, json = await self._remote._put(self.endpoint, **params) | |||
There was a problem hiding this comment.
The _put method has data as the second argument and params shouldn't be expanded. I think it should simply look like this:
| _, json = await self._remote._put(self.endpoint, **params) | |
| _, json = await self._remote._put(self.endpoint, params=params) |
There was a problem hiding this comment.
Sorry, I overlooked that the kwargs are swallowed again in that method, I saw that they were passed along to _request.
What would you think about adding a kwargs parameter there and allow for the same method signature as aiohttp by passing kwargs through from the first call into aiocouch until they reach the couchdb?
There was a problem hiding this comment.
Also: I saw that some tests started to fail because the parameters are no longer ignored. Maybe I need to revisit this whole pull request.
|
I took the liberty to throw together my own patch for the issue. Passing the query options should work with the new release now. Passing kwargs down to |
We want to control database creation, especially the number of shards and the parameter is lost on this line.