Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useNativeDriver whenever possible #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eyalyoli
Copy link

Configure Animted to useNativeDriver whenever possible to:

  1. Improve animation performance
  2. Remove useNativeDriver not set warnings

@RookTKO
Copy link

RookTKO commented Jan 30, 2021

I think this causes conflicts with the ability to stack because we are using useNative everywhere. @eyalyoli thoughts?

@eyalyoli
Copy link
Author

I'll check the stack option. I moved this to a newer version of the project check - https://github.com/swaplet/react-native-swipe-cards-deck

@eyalyoli
Copy link
Author

eyalyoli commented Feb 1, 2021

@RookTKO yes it is a problem, the fix is simply to replace top with translateY and left with translateX in lines 387, 391 when defining style at renderStack(). I fixed this in react-native-swipe-cards-deck.

Although it seems to me that stack mode had issues in the original meteor-factory/react-native-tinder-swipe-cards lib. Maybe you can help to fix these issues...

@RookTKO
Copy link

RookTKO commented Feb 3, 2021

@eyalyoli yea I'll working on trying to resolve them. Seems that they work on ios but not android atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants