Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: python code validation #939

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

j03-dev
Copy link
Contributor

@j03-dev j03-dev commented Dec 13, 2024

Add python code validation on deploy

Migration notes


  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

linear bot commented Dec 13, 2024

@Natoandro
Copy link
Contributor

@j03-dev Can you update the first comment, adding the details of this PR?

@j03-dev j03-dev requested a review from Natoandro December 18, 2024 16:04
Yohe-Am
Yohe-Am previously approved these changes Dec 19, 2024
Natoandro
Natoandro previously approved these changes Dec 24, 2024
@j03-dev j03-dev dismissed stale reviews from Natoandro and Yohe-Am via 6cbfad5 December 25, 2024 12:34
@j03-dev j03-dev force-pushed the feat/met-765-python-code-validation-on-deploy branch from 23782ec to 6cbfad5 Compare December 25, 2024 12:34
@j03-dev j03-dev requested review from Natoandro and Yohe-Am December 25, 2024 17:53
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (6b68642) to head (9e5d743).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/typegate/src/runtimes/python/hooks/mod.ts 80.39% 10 Missing ⚠️
src/typegate/src/typegate/mod.ts 86.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #939   +/-   ##
=======================================
  Coverage   77.72%   77.72%           
=======================================
  Files         153      154    +1     
  Lines       19096    19154   +58     
  Branches     1924     1930    +6     
=======================================
+ Hits        14842    14888   +46     
- Misses       4231     4243   +12     
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j03-dev j03-dev merged commit 87b70e5 into main Dec 27, 2024
12 of 13 checks passed
@j03-dev j03-dev deleted the feat/met-765-python-code-validation-on-deploy branch December 27, 2024 09:47
Natoandro pushed a commit that referenced this pull request Dec 27, 2024
Add python code validation on deploy

---

- [x] The change comes with new or modified tests
- [ ] Hard-to-understand functions have explanatory comments
- [ ] End-user documentation is updated to reflect the change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants