Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exclude files, exts, paths and add new events #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add exclude files, exts, paths and add new events #53

wants to merge 1 commit into from

Conversation

timursevimli
Copy link
Member

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

@timursevimli timursevimli force-pushed the master branch 2 times, most recently from 5d2ee18 to 7e3bd9b Compare November 10, 2023 14:44
tshemsedinov
tshemsedinov requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please do not drop old events
  • Add an issue to deprecate old events before release 2.0
  • Remove line in example in readme

@timursevimli timursevimli force-pushed the master branch 2 times, most recently from 6245432 to a3a8c84 Compare January 9, 2024 14:41
@timursevimli
Copy link
Member Author

  • Added issue with canceling old events before version 2.0.

Should I make an issue about this?
Since the old events remain the same as they were with the same contracts, we simply add new ones

tshemsedinov
tshemsedinov reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Move is* methods out of class
  • Rename events to rmdir, delete

@timursevimli timursevimli force-pushed the master branch 8 times, most recently from 75bb60c to 7cec97c Compare January 24, 2024 22:13
@timursevimli timursevimli force-pushed the master branch 4 times, most recently from d6c2bce to 5eb4255 Compare January 24, 2024 22:44
timursevimli
timursevimli commented Jan 26, 2024
View reviewed changes
test/unit.js
}, WRITE_TIMEOUT);
});

metatests.test('Delete file (rm)', (test) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, need update test descriptions like Delete: rm and Delete: rmdir ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshemsedinov tshemsedinov Awaiting requested review from tshemsedinov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timursevimli @tshemsedinov