Add tolerations for targetless agent.

[meowjesty]

• Issue: https://github.com/metalbear-co/operator/issues/737

[aviramha]

Wait - the sentence in the issue might be tricky but we don't want to use default tolerations on the agent when running targetless.

[meowjesty]

What should happen then? I thought it was about: if user sets tolerations in operator.agent-config, use those, otherwise ... do?

[aviramha]

What should happen then? I thought it was about: if user sets tolerations in operator.agent-config, use those, otherwise ... do?

Otherwise don't set tolerations. (only in targetless)

[meowjesty]

Alright!

[meowjesty]

Removed the default, now it'll just pass the Option.

idk really

[Razz4780]

Not sure why we even have tolerations 👀 :

The default Kubernetes scheduler takes taints and tolerations into account when selecting a node to run a particular Pod. However, if you manually specify the .spec.nodeName for a Pod, that action bypasses the scheduler

We either:

1. (targetless) Don't care about the node at all
2. (targeted) Require a specific node and we use .spec.nodeName

[aviramha]

I believe we saw agent pods failing to start because they lacked the tolerations
I think the scheduler might not care but it will still not start if not tolerated.

[Razz4780]

Looks good ^^