Refactor variables, add text right align setting, add input reader #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the changes and updates! Firstly, incorporating Shellcheck suggestions is excellent as it helps maintain clean and error-free code. Additionally, including pushden in the script directory, along with .shellcheckrc, enhances Visual Studio Code integration, making it easier for Shellcheck to locate variable and function definitions. Moreover, the newly added append right function sounds interesting. |
|
Thank a lot for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pushdinto script directory so shellcheck knows where to source (no need for# shellcheck sourcedirective). This together with the .shellcheckrc makes hovering over variables/functions defined in simple_curses.sh in vscode work.append <text> right--enable-input. It does a bunch of somewhat "nonblocking" reads, technicallyread -n 1 charis blocking but it should always succeed.Let me know what you think about the last feature! I think it is still very rough around the edges.