Use the same bridge for the mgmt network and external connectivity #216
+32
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow to run kind also in the same network for the capi-lab
robertvolkmann
force-pushed
the
enhance-network-for-capms
branch
from
91764ce to
c982c55
Compare
robertvolkmann
force-pushed
the
enhance-network-for-capms
branch
from
c982c55 to
529ed30
Compare
majst01
reviewed
Jan 24, 2025
| s.fileno(), | ||
| 0x891b, # SIOCGIFNETMASK | ||
| struct.pack('256s', iface.encode('utf-8')) | ||
| )[20:24]) |
There was a problem hiding this comment.
This is for sure not working in the ipv6 case
There was a problem hiding this comment.
I never thought about using IPv6 for the management interface. Should I look into it?
There was a problem hiding this comment.
No, some sort of clarification above would help for people not familiar with ioctl, and pydoc that says that this method only works for ipv4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allow to run kind also in the same network for the capi-lab