Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add button to create a new github issue #14

Conversation

filiphric
Copy link
Collaborator

@filiphric filiphric commented Dec 17, 2024

Added a github button that will create a new issue with a simple template

Screenshot 2024-12-17 at 13 52 41
Screenshot 2024-12-17 at 13 52 32

@filiphric filiphric self-assigned this Dec 17, 2024
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metabase-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 0:54am

@filiphric filiphric force-pushed the 13-add-a-shortcut-to-create-a-github-issue-from-within-the-debugger branch from d45a287 to a743b84 Compare December 17, 2024 12:53
Copy link
Collaborator

@thebiglabasky thebiglabasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of renaming references to Slack which is minor, it looks good to me (though I'm by no means carrying any form of review authority 😂)

@@ -77,7 +77,7 @@ export default function Home({
</div>
) : (
<div className="flex-grow">
<DevToolsUI diagnosticData={diagnosticData} />
<DevToolsUI diagnosticData={diagnosticData} slackFileId={fileId} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd name the fileID more generically since we're looking at eventually moving away from slack as the place to host bug report files

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I think it might make sense to change this once we purge debugger from all mentions of slack

@filiphric filiphric merged commit 6c35e5b into main Dec 17, 2024
5 checks passed
@filiphric filiphric deleted the 13-add-a-shortcut-to-create-a-github-issue-from-within-the-debugger branch December 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants