update types

metabase · Jan 8, 2025 · ab77015 · ab77015
1 parent 5bc6f1c
commit ab77015
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/src/components/CreateGithubIssue.test.tsx b/src/components/CreateGithubIssue.test.tsx
@@ -10,8 +10,9 @@ describe('CreateGithubIssue', () => {
       description: 'Test description',
     },
     entityInfo: {
+      name: 'Test Entity',
       entityName: 'Test Entity',
-    }
+    },
   }
 
   beforeEach(() => {
@@ -80,7 +81,8 @@ describe('CreateGithubIssue', () => {
       },
       entityInfo: {
         entityName: '',
-      }
+        name: '',
+      },
     }
 
     render(<CreateGithubIssue diagnosticData={minimalData} />)

diff --git a/src/components/CreateGithubIssue.tsx b/src/components/CreateGithubIssue.tsx
@@ -4,7 +4,7 @@ import type { DiagnosticData } from '@/types/DiagnosticData'
 
 import { Button } from './ui/button'
 interface CreateGithubIssueProps {
-  diagnosticData: DiagnosticData
+  diagnosticData: Pick<DiagnosticData, 'basicInfo' | 'entityInfo'>
   slackFileId?: string
 }
 

diff --git a/src/components/UploadDropzone.tsx b/src/components/UploadDropzone.tsx
@@ -22,7 +22,7 @@ const UploadDropzone: React.FC<UploadDropzoneProps> = ({ onFileUpload }) => {
             const diagnosticData: DiagnosticData = {
               basicInfo: {
                 description: parsedData.description || 'No description provided',
-                url: parsedData.url || 'Unknown URL',
+                url: parsedData.url || '',
                 bugReportDetails: parsedData.bugReportDetails || {},
                 browserInfo: parsedData.browserInfo || {},
               },

diff --git a/src/types/DiagnosticData.ts b/src/types/DiagnosticData.ts
@@ -2,8 +2,10 @@ export interface DiagnosticData {
   basicInfo: {
     url: string
     description?: string
-    bugReportDetails: Record<string, any>
-    browserInfo: Record<string, any>
+    bugReportDetails?: Record<string, any>
+    browserInfo?: Record<string, any>
+    'metabase-info'?: Record<string, any>
+    'system-info'?: Record<string, any>
   },
   entityInfo: {
     entityName: string