-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further changes to make ES 5.0 work #597
base: master
Are you sure you want to change the base?
Conversation
- Removed the ES_HEAP_SIZE env var *entirely*, since ES 5.0 shuts it all down if it finds it. - Removed the args that are passed to ES, since he doesn't appear to accept them anymore. Apparently they have to be given via elasticsearch.yml. - Updated the way ES_JAVA_OPTS environment variable is set, as opposed to ES_HEAP_SIZE. The format is -Xms[MEM][m|g] -Xmx[MEM][m|g].
Can one of the admins verify this patch? |
To see the state of these changes, see #594 |
@nubunto After merge conflicts have been resolved, is this one WIP or ready to be merged? |
@frankscholten I believe further polishing might be needed, e.g. I hardcoded megabytes as the ram size, we should improve this. |
Ok. Can you fix the above conflicts? |
What is the current situation on running ES5 from Mesos Elasticsearch, should it work after this PR is in? |
Hi guys, what is the status? Will you agree to merge when conflicts are resolved? |
Any update about this PR? |
@containersol @nubunto - guys, can we please get the update on this? |
Hey guys. I am really far away from this at the moment, and I really don't have the time to maintain this PR or any work that derives from it. |
down if it finds it.
accept them anymore. Apparently they have to be given via
elasticsearch.yml.
to ES_HEAP_SIZE. The format is -Xms[MEM][m|g] -Xmx[MEM][m|g].