This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Bug fixing & enhancements #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Maluen
commented
Nov 18, 2013
Maluen
commented
- Removed JSON.stringify (issue Watcher not called when assigning a function to the watched attribute #37)
- Added level parameter (issue recursion + infinite loops #30)
- Replaced 'for in' with standard for when iterating over arrays, added the hasOwnProperty check otherwise (issue Use standard for when iterating over array items and add hasOwnProperty check for objects #45)
- Added support for checking arrays in the getObjDiff function
- Removed usage of addNRemove when level is 0
- Removed JSON.stringify (issue melanke#37) - Added level parameter (issue melanke#30) - Replaced 'for in' with standard for when iterating over arrays, added the hasOwnProperty check otherwise (issue melanke#45) - Added support for checking arrays in the getObjDiff function - Removed usage of addNRemove when level is 0
|
Finally I found the time to make the pull request, please take your time to review and test changes. |
|
Thank you very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.