Install setup requirements on-the-fly #101
Conversation
.travis.yml
Outdated
| @@ -36,7 +36,7 @@ install: | |||
| # https://github.com/conda-forge/blas-feedstock/issues/58 | |||
| - conda create -q -n test-env python=$TRAVIS_PYTHON_VERSION | |||
| - conda activate test-env | |||
| - conda install -y -q lapack "libblas=*=*netlib" cython>=0.26 future>=0.15 "ipopt=$IPOPT_VERSION" numpy>=1.15 pkg-config>=0.29.2 setuptools>=39.0 six>=1.11 | |||
| - conda install -y -q lapack "libblas=*=*netlib" "ipopt=$IPOPT_VERSION" pkg-config>=0.29.2 setuptools>=39.0 | |||
There was a problem hiding this comment.
I'd prefer leaving this as is so we pre-install all dependencies from conda. We could have a separate test that attempts to install using pip installed dependencies.
There was a problem hiding this comment.
reverted it!
setup.py
Outdated
| from setuptools import dist | ||
| SETUP_REQUIRES = [ | ||
| "setuptools >= 39.0", | ||
| "wheel >= 0.26.2", |
There was a problem hiding this comment.
I'm not sure why wheel should be a requirement for building the library. Is that only required if you want to create a wheel?
We have #41, but I believe that requires building a wheel for ipopt first.
There was a problem hiding this comment.
afaik binary wheel is python's preferred way of installing packages (not sure how much faster though), therefore it warns that it uses e.g. source fallback when wheel is not installed. but also works without, removed it here.
| "cython>=0.26", | ||
| "future>=0.15", | ||
| "setuptools>=39.0", | ||
| "six>=1.11", |
There was a problem hiding this comment.
It is likely that cython and setuptools are not needed to run the library. We'd need to double check.
There was a problem hiding this comment.
I think Cython could be removed here, but not necessarily numpy. Shouldn't setuptools be a build dep then too? I don't see it used anywhere but setup.py.
There was a problem hiding this comment.
true ... I did not want to meddle too much with the build, but certainly possible that cython/numpy can be removed under install_requires (here I did not change those dependencies at all).
setuptools should technically be a build dep too, however I guess that would only work via pyproject.toml or setup.cfg, as setup.py is completely based on setuptools. afaik, it is usually pre-installed on python distros.
There was a problem hiding this comment.
Understood. The file requires an import of setuptools itself, so it has to be pre-installed. We can leave this as is.
|
Ok, thanks. Hopefully that helps a little downstream. |
Automatically install setup requirements during setup.py based installation. Concerns cython+numpy, i.e. pip dependencies. Apt dependencies will need to be installed separately.
Solves #100