Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added regModel to pimple #746

Merged
merged 9 commits into from
Jan 26, 2025
Merged

Added regModel to pimple #746

merged 9 commits into from
Jan 26, 2025

Conversation

friedenhe
Copy link
Collaborator

No description provided.

@friedenhe friedenhe requested a review from a team as a code owner January 26, 2025 13:25
@friedenhe friedenhe merged commit 2e117cc into mdolab:v4 Jan 26, 2025
2 checks passed
@friedenhe friedenhe deleted the v4_more_dvs branch January 26, 2025 13:25
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 66 lines in your changes missing coverage. Please review.

Project coverage is 58.89%. Comparing base (1389913) to head (3e81cf9).
Report is 1 commits behind head on v4.

Files with missing lines Patch % Lines
src/adjoint/DAFunction/DAFunctionVariance.C 56.19% 46 Missing ⚠️
...oint/DAModel/DATurbulenceModel/DATurbulenceModel.C 82.85% 6 Missing ⚠️
src/adjoint/DASolver/DASolver.C 62.50% 3 Missing ⚠️
...t/DAModel/DATurbulenceModel/DASpalartAllmarasFv3.C 0.00% 2 Missing ⚠️
...rc/adjoint/DAModel/DATurbulenceModel/DAkOmegaSST.C 0.00% 2 Missing ⚠️
src/adjoint/DARegression/DARegression.H 0.00% 2 Missing ⚠️
src/adjoint/DASolver/DAPimpleFoam/DAPimpleFoam.C 81.81% 2 Missing ⚠️
src/adjoint/DAFunction/DAFunctionVariance.H 0.00% 1 Missing ⚠️
src/adjoint/DAInput/DAInputRegressionPar.H 83.33% 1 Missing ⚠️
...oint/DAModel/DATurbulenceModel/DASpalartAllmaras.C 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v4     #746      +/-   ##
==========================================
+ Coverage   56.34%   58.89%   +2.55%     
==========================================
  Files         186      190       +4     
  Lines       14022    14292     +270     
==========================================
+ Hits         7900     8417     +517     
+ Misses       6122     5875     -247     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

friedenhe added a commit that referenced this pull request Jan 30, 2025
* Change version to v4 for all files (#686)

* Removed GH actions.

* Changed version to v4 for all files.

* Verified totals for DASimpleFoam (#715)

* Added first lib with test yml.

* Fixed a bug in the test script.

* Added the first v4 test.

* Added the missing DAOption Make.

* Added test codecov

* Update and rename codecov.yml to code_cov.yml

* Added unit_test verification mechanism

* Unify the incompressible and compressible libs.

* Added more libs.

* Renamed DAObjFunc to DAFunction.

* More renames.

* Re-structue the DAFunction.

* Added more libs and delete unused DAPart and DAJac sub classes.

* DASOlver compiled.

* Re-organized coloring util.

* Re-organized pyDASolvers.

* Fixed the unit test setup file.

* Added the DAInput and DAOutput classes.

* Added -w to all the options files to disable warnings.

* Changed the interfaces for many classes.

* Changed the Allmake files.

* Changed init file.

* Changed mphys and pyDAFoam python layers.

* Changed DASolver and add calcJacTVecProduct function.

* Fixed an issue in init file.

* DAOutput uses its own dicts.

* Added the missing pip install for tests.

* Total accurate for DASimpleFoam.

* Enabled new build modes (#723)

* Fixed a bug for the distributed flag for functions

* Fixed all the Make files.

* Changed the AD -D name to CODI_NO_AD, CODI_ADR and CODI_ADF.

* Changed the cython lib compilation method.

* Changed the pre and post-processing build.

* Changed the python files to new build.

* Added a new libs folder for the cython libs.

* Changed the github action files.

* Added the ADR build in the github action.

* Fixed a bug in the GH action file.

* Fixed the unit test script.

* Added regression, unit, and coverage test templates (#724)

* Fixed a bug for the distributed flag for functions

* Added DASimpleFoam test.

* Fixed codecov test.

* Fixed a bug in codecov

* Added Python coverage.

* Added more tracking files.

* Fixed a codecov typo

* Changed the all run script for test such that it will run all the tests.

* Added checkMesh and printRes to primals.

* Added DARhoSimpleFoam (#726)

* Fixed a bug for the distributed flag for functions

* Made printInterval and maxRes class-wide vars.

* Added the DARhoSimpleFoam tests.

* Fixed test files.

* Added the missing file.

* Enabled forward model and verified adjoint accuracy (#727)

* Fixed a bug for the distributed flag for functions

* Enabled forward mode AD. Verified machine-precision accurate adjoint for DASimpleFoam

* Added new interfaces for inputs (#733)

* Removed 2> log for test files.

* Re-organize input and output. Added patchVelocity

* Added dF back for patchVelocity.

* Enabled CD and CL based on AOA.

* Enabled auto make mode.

* Print info for DAInput and calcJac.

* Changed designVar to solverInput and re-organized all partial calls.

* Added more solvers and functions. (#734)

* Removed the distributed arg for calcJac.

* Added DARhoSimpleCFoam.

* Added DAHeatTransferFoam and related functions.

* Added the missing files.

* Fixed the DATurb order.

* Used mpicc to auto-detect include and lib paths.

* Added DASimpleTFoam and related functions.

* Added the missing files.

* Added kOmegaSST and moved Coloring into DASolver.

* Fixed the code cov.

* Re-organized new turbModel structure and added Fv3 and laminar models.

* Added the moment function.

* Fixed an issue to avoid computing all dF partials.

* Removed un-used funcs in Python layer.

* Removed unused funcs in DASolver.

* Removed parts for DAFunction and re-organized codes.

* Added pimple adjoint and verified totals  (#737)

* Added DAPimpleFoam and primal working.

* Updated the pimple ref.

* Added pimple and verified derivs

* Fixed a critical bug about normRes.

* Added the updatePC call back.

* Updated ref.

* Updated simpleFoam refs.

* Added shape var for pimple. Totals not accurate yet.

* Tested pimple shape with forward and the totals are accurate.

* Added forward tests and changed function interfaces (#741)

* Added DATimeOp and re-organized evalFunctions.

* Added forward AD test.

* Added flags to compile forward mode.

* Renamed the test refs

* Moved old test files.

* Added forward tests and FD refs.

* Add pimpleDym primal (#744)

* Added pimpleDyM.

* Added the docker deploy yml.

* Change pimpledym test file name

* Enabled ADF for docker build

* Fixed an issue in the docker build yml

* Added more inputs, changed solverInto to inputInfo, and added aerothermal (#745)

* Added field input and verifed its totals.

* Added tests for vector field.

* Added the patchVar input.

* Added CHT.

* Added the missing files.

* Added the missing flag.

* Added regModel to pimple (#746)

* Enabled regression par as dv.

* Deleted DAMotion and DARegDb classes

* Removed regDb dependencies.

* Deleted unused models.

* Renamed models to DAMisc

* Moved boundaryConditions to DAMisc.

* Changed the test file name

* Added variance func.

* Added regModel for pimple with a test.

* Removed outdated codes (#747)

* Allowed empty function.

* Removed outdated codes.

* Renamed thermalVar to thermalCoupling.

* Updated the aerothermal test script.

* Fixed aerothermal.

* Added aerostructural (#748)

* Added forceCoupling for FSI.

* Verified the AeroStruct total.

* Removed the masks, aeroProp, and acoustics in mphys_dafoam.

* Adjusted the aero-struct tolerance.

* Added all solvers and functions back (#750)

* Deleted Laplacian and Piso.

* Deleted scalarTransport

* Added turboFoam and mass flow rate func.

* Deleted outdated functions and added all functions back.

* Deleted outdated res and stateInfo.

* Added rhoPimple

* Added all turb models.

* Changed the primalMaxRes calculation.

* Added more tests and fixed issues.

* Added more tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant