Temporal edits #37905
Open
Temporal edits #37905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Temporal object would represent a date outside of the supported range, this always throws a RangeError, regardless of the value of the overflow option.
github-actions
bot
added
Content:JS
|
Thanks! Is this ready to review as-is, or do you plan to add more stuff to it? |
|
I figured I'd keep this easy to review and open a separate PR when I have another batch of edits, so this is ready to review. (If you'd prefer that I just make one PR instead, let me know and I'll do that.) |
github-actions
bot
added
size/m
|
Weirdly, I can't push to your branch that I checked out with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple of minor edits to the Temporal docs: a few mislabeled or missing links, a clarification about ±HH:mm:ss.sssssssss offset parts of RFC 9557 strings, and another clarification about the representable range covered by Temporal objects.
Motivation
I was asked to pitch in to help review the original Temporal docs PR, but didn't have time. So I'm going over it now and fixing anything that comes to mind. This is the result of one session of doing that.
Additional details
Related issues and pull requests
Relates to #37344