Fix example in ARIA: grid role #37903
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the incorrect use of `rowIndex` with `colIndex` in the JavaScript example code for initializing the cell datasets. This error resulted in incorrect `row` and `col` values on the cells, causing the navigation to not work correctly. Pressing PageDown resulted in an endless `do` ... `while` loop that nearly consumed all of my computer's memory over the next few minutes.
github-actions
bot
added
Content:Accessibility
|
Preview URLs |
estelle
reviewed
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the incorrect use of
rowIndexwithcolIndexin the JavaScript example code for initializing the cell datasets.Motivation
This error resulted in incorrect
rowandcolvalues on the cells, causing the navigation to not work correctly. Pressing PageDown resulted in an endlessdo...whileloop that nearly consumed all of my computer's memory over the next few minutes.Additional details
It might also be good to add a
default: return;case to the "keydown" event to avoidevent.preventDefault()for other keys. I think this JavaScript code could use some more improvements to make it more clear and concise, but I'll leave that to someone that is familiar with MDN's code style guidelines.