Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: swap a word in sentence #37902

Merged
merged 2 commits into from
Feb 6, 2025
Merged

docs: swap a word in sentence #37902

merged 2 commits into from
Feb 6, 2025

Conversation

vladboisa
Copy link
Contributor

Fixes #37889

Description

Swap the sentence for more "clear" version

Motivation

Additional details

Related issues and pull requests

@vladboisa vladboisa requested a review from a team as a code owner January 31, 2025 16:38
@vladboisa vladboisa requested review from sideshowbarker and removed request for a team January 31, 2025 16:38
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Preview URLs

(comment last updated: 2025-02-06 00:58:02)

Swap the sentence for more "clear" version


Fixes mdn#37889
@Josh-Cena
Copy link
Member

This is not what the issue asks. The issue asks whether this word is correct, because "focus" means "selection end", and asks if "selection start" is the correct version. Your edit did not change the meaning of the sentence. If you want to make an edit, you first have to figure out which version is the correct version.

@vladboisa
Copy link
Contributor Author

This is not what the issue asks. The issue asks whether this word is correct, because "focus" means "selection end", and asks if "selection start" is the correct version. Your edit did not change the meaning of the sentence. If you want to make an edit, you first have to figure out which version is the correct version.

Thanks for answering and clarifying it's for me.
I asked in the issue, and after discussing it, I'll propose a new change :)
Thanks for letting me help the open source community!

@sideshowbarker sideshowbarker removed their request for review February 1, 2025 13:25
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into the problem. Neither "start" nor "end" is accurate because the "anchor" can be either the start or end. Rather, this is just because this paragraph is copy/pasted from focusOffset.

@Josh-Cena Josh-Cena merged commit e1663b9 into mdn:main Feb 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I think "focus" does not belong here
2 participants