-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ia): reorg Web/Media #37898
base: main
Are you sure you want to change the base?
chore(ia): reorg Web/Media #37898
Conversation
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew! What a chunk of work :) LGTM, thanks!
(apart from a little pesky tag, sorry)
@@ -36,7 +35,7 @@ The code below is an example of a basic audio implementation using HTML5: | |||
- `src` contains the path to the audio file to be loaded (relative or absolute). | |||
- `type` is used to inform the browser of the file type. If omitted, most browsers will attempt to guess this from the file extension. | |||
|
|||
- If the {{ htmlelement("audio") }} element is not supported then {{ htmlelement("audio") }} and {{ htmlelement("source") }} will be ignored. However, any supported text or elements that you define within {{ htmlelement("audio") }} will be displayed or acted upon. So the ideal place to create a fallback or inform of incompatibility is before the closing `</audio>` tag. In this case, we've provided a simple paragraph including a link to download the audio directly. | |||
- If the {{ htmlelement("audio") }} element is not supported then {{ htmlelement("audio") }} and {{ htmlelement("source") }} will be ignored. However, any supported text or elements that you define within {{ htmlelement("audio") }} will be displayed or acted upon. So the ideal place to create a fallback or inform of incompatibility is before the closing `</audio>` element. In this case, we've provided a simple paragraph including a link to download the audio directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If the {{ htmlelement("audio") }} element is not supported then {{ htmlelement("audio") }} and {{ htmlelement("source") }} will be ignored. However, any supported text or elements that you define within {{ htmlelement("audio") }} will be displayed or acted upon. So the ideal place to create a fallback or inform of incompatibility is before the closing `</audio>` element. In this case, we've provided a simple paragraph including a link to download the audio directly. | |
- If the {{ htmlelement("audio") }} element is not supported then {{ htmlelement("audio") }} and {{ htmlelement("source") }} will be ignored. However, any supported text or elements that you define within {{ htmlelement("audio") }} will be displayed or acted upon. So the ideal place to create a fallback or inform of incompatibility is before the closing `</audio>` tag. In this case, we've provided a simple paragraph including a link to download the audio directly. |
In this case, it’s a tag. Sorry! 😅
Description
Drafting a Media reorg PR. Directory now has this structure:
Changes:
Files to look at with actual content changes:
files/en-us/web/media/index.md
files/en-us/web/media/guides/index.md
files/en-us/web/media/guides/formats/index.md
Files with minor fixes:
files/en-us/web/media/guides/audio_and_video_delivery/cross-browser_audio_basics/index.md
files/en-us/web/media/guides/audio_and_video_delivery/index.md
<source>
/ other elements properly closedfiles/en-us/web/media/guides/audio_and_video_manipulation/index.md
files/en-us/web/media/guides/dash_adaptive_streaming_for_html_5_video/index.md
Everything else:
All other files change links to the section, nothing to look too closely at.
Motivation
Generating a preview for docs IA & maintenance tasks