Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(workflows/pr-check): validate redirects with rari + fix only en-US #37867

Merged
merged 7 commits into from
Jan 30, 2025
Merged

chore(workflows/pr-check): validate redirects with rari + fix only en-US #37867

merged 7 commits into from
Jan 30, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 29, 2025 •
edited
Loading

Reverts #37844 and #37822, as support for both has landed in rari: mdn/rari#103

@caugner caugner requested a review from a team as a code owner January 29, 2025 17:10
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label Jan 29, 2025
@caugner caugner marked this pull request as draft January 29, 2025 17:10
@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed and removed system [PR only] Infrastructure and configuration for the project size/xs [PR only] 0-5 LoC changed labels Jan 29, 2025
@caugner caugner changed the title Revert "fix(redirects): remove locale param + validate with legacy" chore(workflows/pr-check): validate redirects with rari + fix only en-US Jan 29, 2025
@caugner caugner force-pushed the revert-37844-fix-lint-staged branch from 980b3bf to 165cbd3 Compare January 29, 2025 17:21
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jan 29, 2025
@caugner caugner marked this pull request as ready for review January 29, 2025 17:26
@caugner caugner requested a review from mdn-bot as a code owner January 29, 2025 17:26
@caugner caugner force-pushed the revert-37844-fix-lint-staged branch from 63826a2 to 75d0fff Compare January 29, 2025 17:26
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Jan 29, 2025
argl
argl approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caugner caugner merged commit 63f1774 into main Jan 30, 2025
17 of 18 checks passed
@caugner caugner deleted the revert-37844-fix-lint-staged branch January 30, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argl argl argl approved these changes

@mdn-bot mdn-bot Awaiting requested review from mdn-bot

Assignees
No one assigned
Labels
size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caugner @argl