Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make task requirement consistent with the solution #37752

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

youssef-el-atmani
Copy link
Contributor

It is a simple change,
I in the Task 2 it is required that the border should have 1px, And the solution has 2px, also the image provided look a lot more like a 2px.

Description

update a Task requirement to be consistent with the solution provided

Motivation

Make the Exercise consistent

Additional details

Related issues and pull requests

It is a simple change,
I in the `Task 2` it is required that the border should have `1px`,
And the solution has `2px`, also the image provided look a lot more like a `2px`.
@youssef-el-atmani youssef-el-atmani requested a review from a team as a code owner January 22, 2025 09:30
@youssef-el-atmani youssef-el-atmani requested review from hamishwillee and removed request for a team January 22, 2025 09:30
@github-actions github-actions bot added the size/xs [PR only] 0-5 LoC changed label Jan 22, 2025
Copy link
Contributor

Preview URLs

Flaws (251)

URL: /en-US/docs/Learn_web_development/Core/Styling_basics/Basic_selectors/Selectors_Tasks
Title: Test your skills: Selectors
Flaw count: 251

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/Installing_basic_software
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/What_will_your_website_look_like
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/Dealing_with_files
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/HTML_basics
    • and 246 more flaws omitted

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 782d887 into mdn:main Jan 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants