Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify BigInts are integers #37741

Merged
merged 3 commits into from
Jan 21, 2025
Merged

docs: clarify BigInts are integers #37741

merged 3 commits into from
Jan 21, 2025

Conversation

mxdvl
Copy link
Contributor

@mxdvl mxdvl commented Jan 21, 2025

Description

“Numeric” values is too loose a term.

Motivation

Clarify that BigInt are in fact only integers, not any numeric value. There’s also some possible confusion from using referencing numbers that are “too large”, but no reference to Number.MIN_SAFE_INTEGER.

Additional details

Related issues and pull requests

N/A

@mxdvl mxdvl requested a review from a team as a code owner January 21, 2025 17:19
@mxdvl mxdvl requested review from Josh-Cena and removed request for a team January 21, 2025 17:19
@github-actions github-actions bot added the Content:JS JavaScript docs label Jan 21, 2025
@github-actions github-actions bot added the size/xs [PR only] 0-5 LoC changed label Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Preview URLs

(comment last updated: 2025-01-21 17:23:47)

large is not accurate enough
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks!

@Josh-Cena Josh-Cena merged commit 00e97c5 into mdn:main Jan 21, 2025
9 checks passed
@mxdvl mxdvl deleted the patch-1 branch January 22, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants