-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all info about supported Intl identifiers under supportedValuesOf, sync with latest CLDR #37735
Open
Josh-Cena
wants to merge
3
commits into
mdn:main
Choose a base branch
from
Josh-Cena:move-supported-values
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f, sync with latest CLDR
Josh-Cena
requested review from
sideshowbarker and
bsmth
and removed request for
a team and
sideshowbarker
January 21, 2025 06:31
github-actions
bot
added
Content:JS
JavaScript docs
size/l
[PR only] 501-1000 LoC changed
labels
Jan 21, 2025
bsmth
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always find it weird that our canonical place of documentation for the calendar/numbering system/collation identifiers is the
Intl.Locale
API, because you don't get an exhaustive list from this API. OTOHIntl.supportedValuesOf()
is guaranteed to return an exhaustive list, so it is much easier to verify the results. In addition I'm syncing the documentation with the latest CLDR which introduces more numbering systems, and more explicitly marking some collation types as deprecated.