Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonexistent menu items now return an error message #37720

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Jan 20, 2025

Description

Addresses the dev docs needed requirements of Bug 1688743 menus.remove doesn't return an error when removing a non-existing menu item.

Adds a release note. Reference documentation already indicates that the relevant APIs should return an error message.

Related issues and pull requests

Related to BCD note added in TBC

@rebloor rebloor added the Content:WebExt WebExtensions docs label Jan 20, 2025
@rebloor rebloor requested review from dotproto and Rob--W January 20, 2025 01:36
@rebloor rebloor self-assigned this Jan 20, 2025
@rebloor rebloor requested a review from a team as a code owner January 20, 2025 01:36
@rebloor rebloor requested review from pepelsbey and removed request for a team January 20, 2025 01:36
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed and removed Content:WebExt WebExtensions docs labels Jan 20, 2025
Copy link
Contributor

github-actions bot commented Jan 20, 2025

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/136
Title: Firefox 136 for developers

(comment last updated: 2025-01-20 06:54:34)

@Rob--W Rob--W merged commit 11611c3 into mdn:main Jan 29, 2025
9 checks passed
@rebloor rebloor deleted the nonexistent-menu-items-return-error branch January 30, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants