Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptor requirement to @font-face #37709

Merged

Conversation

ryo-manba
Copy link
Contributor

Description

Added a missing requirement.

Motivation

Clarifies the spec:

@font-face rules require a font-family and src descriptor; if either of these are missing, the @\font-face rule must not be considered when performing the font matching algorithm.
CSS Fonts Module Level 4

Additional details

The wording follows the same style as the description for the @font-face src descriptor.

Related issues and pull requests

@ryo-manba ryo-manba requested a review from a team as a code owner January 19, 2025 02:58
@ryo-manba ryo-manba requested review from chrisdavidmills and removed request for a team January 19, 2025 02:58
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Jan 19, 2025
Copy link
Contributor

github-actions bot commented Jan 19, 2025

Preview URLs

Flaws (48)

URL: /en-US/docs/Web/CSS/@font-face
Title: @font-face
Flaw count: 48

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted

(comment last updated: 2025-01-21 13:27:31)

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Jan 21, 2025
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ryo-manba, and thank you for the improvement to this page!

Your update looks fine, but while I was here I decided to make a couple of grammar improvements to the page too. I hope you don't mind.

@chrisdavidmills chrisdavidmills merged commit ff5694d into mdn:main Jan 21, 2025
9 checks passed
@ryo-manba ryo-manba deleted the add-descriptor-requirement-to-font-face branch January 22, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants