Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misleading javascript conflict example #37695

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

NemoZon
Copy link
Contributor

@NemoZon NemoZon commented Jan 17, 2025

Description

explain why the function is not overwritten

Motivation

working on Issue #37549

Additional details

Related issues and pull requests

Fixes #37549

@NemoZon NemoZon requested a review from a team as a code owner January 17, 2025 14:43
@NemoZon NemoZon requested review from chrisdavidmills and removed request for a team January 17, 2025 14:43
@github-actions github-actions bot added the size/xs [PR only] 0-5 LoC changed label Jan 17, 2025
Copy link
Contributor

github-actions bot commented Jan 17, 2025

Preview URLs

Flaws (251)

URL: /en-US/docs/Learn_web_development/Core/Scripting/Functions
Title: Functions — reusable blocks of code
Flaw count: 251

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/Installing_basic_software
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/What_will_your_website_look_like
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/Dealing_with_files
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/HTML_basics
    • and 246 more flaws omitted

(comment last updated: 2025-01-17 19:43:12)

@NemoZon
Copy link
Contributor Author

NemoZon commented Jan 17, 2025

I hope this description will be sufficient, but if not, please let me know.

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have some suggestion for rewording, but I decided to just commit that to your branch. I mainly just added another paragraph saying what should happen if just the function gets redeclared. Thanks!

@Josh-Cena Josh-Cena merged commit d2c90c8 into mdn:main Jan 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading javascript conflict example
2 participants