Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js): Move external XHR example into page #36809

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 15, 2024

Description

In the JS examples repo, most are about modules which I'm not touching. There's one example using XHR that we can move into content.

Original code lives here: https://github.com/mdn/js-examples/blob/main/promises-test/index.html

Changes:

  • var -> const
  • arrow functions
  • use a shared asset

Related issues and pull requests

@bsmth bsmth requested a review from a team as a code owner November 15, 2024 10:36
@bsmth bsmth requested review from Josh-Cena and removed request for a team November 15, 2024 10:36
@github-actions github-actions bot added Content:JS JavaScript docs size/m [PR only] 51-500 LoC changed labels Nov 15, 2024
Copy link
Contributor

@Josh-Cena Josh-Cena merged commit 5cfbf89 into mdn:main Nov 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants