-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(css): Move CSS examples - Shapes, transforms, transition, display #36740
Merged
Merged
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7202e7c
chore(css): Move CSS examples - Basic shapes with shape-outside
bsmth fc7f718
chore(css): Move CSS examples - Shapes from box values
bsmth 78d91b0
chore(css): Move CSS examples - Overview of shapes
bsmth c41545c
chore(css): Move CSS examples - Shapes from images
bsmth b8b95e1
chore(css): Move CSS examples - CSS transforms
bsmth a35259e
chore(css): Move CSS examples - Using CSS transitions
bsmth 29ecc08
chore(css): Move CSS examples - Using the multi-keyword syntax with C…
bsmth a734619
Merge branch 'main' into css-examples-web-css-3
bsmth c4d180d
chore(css): Move CSS examples - Fix shared assets URL
bsmth 695f843
Merge branch 'main' into css-examples-web-css-3
bsmth bb6eb42
Merge branch 'main' into css-examples-web-css-3
bsmth f89800f
Merge branch 'main' into css-examples-web-css-3
bsmth 7c96c0d
Merge branch 'main' into css-examples-web-css-3
bsmth 0b282f8
Merge branch 'main' into css-examples-web-css-3
bsmth c22e6d2
chore(css): Fixes following reviewer feedback
bsmth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, I'm not sure if this is just a problem with the preview page, but the example is not rendering on the page. The references must be correct because it loads correctly in the MDN Playground.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is strange, I did notice the output box was empty occasionally on localhost, but had content on refresh, I wonder if it's a Playground problem with lazy loading / order of loading resources. Needs some investigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisdavidmills this is a known issue due to changes in Playground envs, it should be resolved in the coming days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. In that case, I'm happy with all the additions, except where commented.