Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts-weight descriptor #36686

Merged
merged 18 commits into from
Nov 29, 2024
Merged

Fonts-weight descriptor #36686

merged 18 commits into from
Nov 29, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Nov 7, 2024

Replaces #32853
Fixes #32619
Fixes #10910

@estelle estelle requested a review from a team as a code owner November 7, 2024 09:17
@estelle estelle requested review from chrisdavidmills and removed request for a team November 7, 2024 09:17
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Nov 7, 2024
@estelle estelle requested a review from wbamberg November 7, 2024 09:17
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Preview URLs

External URLs (2)

URL: /en-US/docs/Web/CSS/@font-face/font-weight
Title: font-weight

(comment last updated: 2024-11-29 00:24:21)

@estelle estelle changed the title Fonts; replaces 32619 Fonts-weight descriptor Nov 7, 2024
@estelle estelle requested review from a team and wbamberg and removed request for wbamberg November 7, 2024 09:20
@estelle estelle requested a review from wbamberg November 12, 2024 19:44
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Estelle! I like this example much better now, here's a detail-level review.

files/en-us/web/css/@font-face/font-weight/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/font-weight/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/font-weight/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/font-weight/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/font-weight/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/font-weight/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/font-weight/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/font-weight/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/font-weight/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/font-weight/index.md Outdated Show resolved Hide resolved
@estelle estelle requested a review from wbamberg November 16, 2024 05:23
@chrisdavidmills chrisdavidmills removed their request for review November 19, 2024 13:06
@wbamberg
Copy link
Collaborator

I like this a lot better but I can't re-review until the live samples in previews are fixed, which I think it a thing neither of us can do.

@estelle
Copy link
Member Author

estelle commented Nov 26, 2024

@wbamberg They are showing up for me locally. The console on this PR is reporting a 404 and not a cors issue, so I think the missing files are a PR environment issue, and merging should be ok.

I like this a lot better but I can't re-review until the live samples in previews are fixed, which I think it a thing neither of us can do.

@estelle
Copy link
Member Author

estelle commented Nov 26, 2024

Screenshot From my localhost 2024-11-25 at 4 07 05 PM

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @estelle !

@wbamberg wbamberg merged commit e454e36 into main Nov 29, 2024
9 checks passed
@wbamberg wbamberg deleted the fonts branch November 29, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
2 participants