-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTCDataChannelStats - add docs #32498
Conversation
- {{domxref("RTCDataChannelStats.state", "state")}} | ||
- : The {{domxref("RTCDataChannel.readyState", "readyState")}} of the associated `RTCDataChannel`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI This is marked as required
in the IDL, as are the common properties below. The rest are not, and are therefore optional. I've marked those as optional inline here for the other ones, but how should I mark up the detailed property docs as there is no "Optional header" macro?
The whole thing is a bit odd because this isn't like a dictionary passed as an argument - the required
is more an instruction to the browser vendor that they are expected to provide the information rather than to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how should I mark up the detailed property docs as there is no "Optional header" macro?
I would just leave this. As you say it is a weird case.
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
d648ac0
to
d52bb13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of super-nits, so approving but not merging.
Co-authored-by: wbamberg <[email protected]>
Thanks very much for merging (and also for reviewing). I thought there would be more to it than this so had been waiting to find a spare few hours. |
This adds docs for
RTCDataChannelStats
, a "codec statistics" object/dictionary you can get by iterating aRTCStatsReport
.It is not very exciting. Largely following the same patterns as the other docs.
This is part of the ongoing work to finished RTC stats, which was started in #27028