Merge pull request #22 from andy-trimble/master

Fixed a bug where the value of 0xe0 would not parse correctly.
mcollina · May 22, 2015 · dbc4f0c · dbc4f0c
2 parents 43b5627 + c61e6e6
commit dbc4f0c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/lib/decoder.js b/lib/decoder.js
@@ -294,7 +294,7 @@ module.exports = function buildDecode(decodingTypes) {
       } else {
         return null
       }
-    }  else if (first > 0xe0) {
+    }  else if (first >= 0xe0) {
       // 5 bits negative ints
       result = first - 0x100
       return buildDecodeResult(result, 1)

diff --git a/lib/encoder.js b/lib/encoder.js
@@ -104,7 +104,7 @@ module.exports = function buildEncode(encodingTypes) {
           write64BitUint(buf, obj)
         }
       } else {
-         if (obj > -32) {
+         if (obj >= -32) {
           buf = new Buffer(1)
           buf[0] = 0x100 + obj
         } else if (obj >= -128) {

diff --git a/test/5-bits-negative-integers.js b/test/5-bits-negative-integers.js
@@ -7,7 +7,7 @@ test('encoding/decoding 5-bits negative ints', function(t) {
     , allNum  = []
     , i
 
-  for (i = 1; i < 32; i++) {
+  for (i = 1; i <= 32; i++) {
     allNum.push(-i)
   }
 

diff --git a/test/8-bits-signed-integers.js b/test/8-bits-signed-integers.js
@@ -8,7 +8,7 @@ test('encoding/decoding 8-bits big-endian signed integers', function(t) {
     , allNum  = []
     , i
 
-  for (i = 32; i <= 128; i++) {
+  for (i = 33; i <= 128; i++) {
     allNum.push(-i)
   }